Update websocket.h function "void do_read()" #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you write UT to show that problem exists? Because it looks like state isn't changed from |
Add test code print log
The log output is as follows
|
|
But it's weird that moment earlier same amount of data are read at once. |
|
So async_read_some() is not guaranteed to read the message data;The above problem occurs when binary audio data is transmitted using WebSocket, with 25 packets per second。 |
|
That's true. But you can only add else block, without assigning |
|
Thanks! I've merged it to my fork :) |
GerHobbelt
pushed a commit
to GerHobbelt/crow
that referenced
this pull request
Apr 13, 2022
Split up operator""_method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for update:
When state_ == WebSocketReadState::Payload, The function async_read_some() is not guaranteed to read all the data.
When remaining_length_ != 0 , you need to continue reading.